Code criticism and advice
- Thread starter Kuzni
- Start date
- Status
PebbleHost
High performance, consistent uptime and fast support. Minecraft hosting that just works.
Use Gradle as your dependency management.
Maybe have different methods like "registerCommands" or "registerListeners" in your main class to handle commands/listeners, up to you though. Also, you should look into DI (dependency injection) or here or a million other sites.
Also, I don't think you should be using static variables in your StaffUtil class for checking if they're in vanish/staff mode (also use a Set instead of a List, and follow the Liskov Substitution Principle). Also for things like saying "flight enabled" or "flight disabled" you could use ternary operators. And for actually toggling flight you could use inverse booleans. It may just be me, but I prefer to use abstraction/annotations for handling commands. Too me, most of the Util classes are using static for things they shouldn't be.[DOUBLEPOST=1545245191][/DOUBLEPOST]if i linked anything that was wrong, please reply to me and tell me
Maybe have different methods like "registerCommands" or "registerListeners" in your main class to handle commands/listeners, up to you though. Also, you should look into DI (dependency injection) or here or a million other sites.
Also, I don't think you should be using static variables in your StaffUtil class for checking if they're in vanish/staff mode (also use a Set instead of a List, and follow the Liskov Substitution Principle). Also for things like saying "flight enabled" or "flight disabled" you could use ternary operators. And for actually toggling flight you could use inverse booleans. It may just be me, but I prefer to use abstraction/annotations for handling commands. Too me, most of the Util classes are using static for things they shouldn't be.[DOUBLEPOST=1545245191][/DOUBLEPOST]if i linked anything that was wrong, please reply to me and tell me
Last edited:
It is clear you need to look into different design patterns, especially OOP; as addressed by Ambrosia. Please, please, please run all your database queries and executions OFF the main thread, and cache your results where possible.
Whenever a player moves, interacts, places a block, etc, multiple database queries are being made: shown in this class of which none are being cached or off the main thread. I really hope this plugin isn't being used on a live server as it could lead to significant performance issues.
Also, FilterListener will deny any use of a capital L, including if it's in the middle of a sentence.
Whenever a player moves, interacts, places a block, etc, multiple database queries are being made: shown in this class of which none are being cached or off the main thread. I really hope this plugin isn't being used on a live server as it could lead to significant performance issues.
Also, FilterListener will deny any use of a capital L, including if it's in the middle of a sentence.
Last edited:
Or just learn to use simple getters and setters. Lombok isn't just for getters and setters lol
ooh a skripter!! Anyways i never even mentioned getters and setters all i said was learn to use Lombok since you can use it for more than getters and setters.
How am I a skripter lmfao, I'm ded LOL?
it doesn’t say skripter exactly but you get my point.
ah yes
- Status
