Critique my Code

[Nyarrth]

Hi.

I am looking for constructive criticism on how I can improve my overall code design, in projects that I have released the source for. I've mainly worked on these plugins during my freetime while learning Bukkit over the past 4 years.

I've decided to get into Mobile/NodeJS Development along with Networking.

My GitLab Group (Minigame Network): https://gitlab.com/mine-aqua
My GitLab Profile: https://gitlab.com/shaunagostinho

 

[Gametron]

Here's a few things to note:

• Instead of checking the value of a variable in multiple if statements, you could use a switch statement. You've done this at least in some places, which is good.
  
• Secrets (passwords, API keys etc.) should be stored in environment variables that is not part of version control.
• In general, you don't want to push IDE-specific settings (the .idea folder in this case) to version control.
• Whitespace use is a bit inconsistent sometimes. In most cases, one line break is enough.
• When your codebase gets larger and more complex, you might want to document it. One way to do it in Java is by writing an API documentation with Javadoc. It's not needed in every project but definitely something to look into and get familiar with since the same concept applies to other languages too.

The most critical of these is definitely the second one.

Good luck with learning mobile and Node.js development!