DonatorPerks | FREE & OPEN SOURCE DONATOR PLUGIN

[subbotted]

Configuration
​

# Toggle /donatorperks [speed/strength/haste/nightvision] command
toggle_command: true

# Toggle donator broadcast (Default: &aOnline <rankname> Players: &r<donators>)
toggle_broadcast: false

# Edit donator broadcast group
donator_broadcast_group: 'default'

# Edit donator broadcast
donator_broadcast_message: '&aOnline <rankname> Players: &r<donators><newline>&7This can be purchased at our store @ <storeurl>'

# Edit donator rank name on broadcast
donator_rank_name: 'Obsidian'

# Edit store url on broadcast
donation_store_url: 'http://mc-market.org/'

# Edit time between each donator broadcast (in minutes)
donator_broadcast_delay: 5

Screenshot(s)

GitHub [Latest build will always be on here]
https://github.com/subbotted/DonatorPerks

Download is in Attached Files (DonatorPerks.zip)​

 

[subbotted]

Reserved

 

[Vail]

Nice one mate!

 

[dawn]

Will possibly use this Sosa

 

[Fle]

Interesting

 

[DedicatedRam]

This looks nice bro!

 

[Conflicted]

Reserved

I like the idea

 

[Irantwomiles]

Pretty shit, vouch

 

[Zooply]

This looks cool, im keeping a tab on this page

 

[Missionary]

Looks good subbotted

 

[subbotted]

Awesome, this is as good as it can get.

Only thing I'd change would be the command part but it isn't even that big of a deal. (Though you would use less lines )

subbotted Check my commit

Oh nice

I tried to make my code as clean as possible but on the command I guess I slacked a bit

 

[Samuel]

Code isn't clean and OH MY FUCKING GOD, DO I SEE TABS?!!!!

WHY WOULD YOU INDENT WITH TABS!?????????????????????????????

4 spaces FTW.[DOUBLEPOST=1492425808][/DOUBLEPOST]Seems that https://github.com/subbotted/DonatorPerks/blob/master/src/com/subbotted/utils/PotionUtils.java is completely useless because you're just calling methods on the player class[DOUBLEPOST=1492425840][/DOUBLEPOST]https://github.com/subbotted/DonatorPerks/blob/master/src/com/subbotted/DonatorPerks.java#L17
I recommend bukkit's ChatColor[DOUBLEPOST=1492425881][/DOUBLEPOST]https://github.com/subbotted/DonatorPerks/blob/master/src/com/subbotted/DonatorPerks.java#L50
Add a return so that you don't keep "enabling" just before it gets disabled.[DOUBLEPOST=1492425921][/DOUBLEPOST]https://github.com/subbotted/DonatorPerks/blob/master/src/com/subbotted/DonatorPerks.java#L80
That's probably gonna return 0 if it's not in the config. Add default value 1 or something.[DOUBLEPOST=1492426033][/DOUBLEPOST]https://github.com/subbotted/DonatorPerks/blob/master/src/com/subbotted/DonatorPerks.java#L119
Split this line up into more lines (ideally use some variables) so that it becomes a bit more readable. Ternary Ops and concatenation don't usually go well together, especially in long lines.[DOUBLEPOST=1492426110][/DOUBLEPOST]https://github.com/subbotted/DonatorPerks/blob/master/src/com/subbotted/DonatorPerks.java#L70
Split your .replace()'s up onto new lines (just next line, do not leave line gaps).[DOUBLEPOST=1492426174][/DOUBLEPOST]Side note: why did you commit stuff that shouldn't be committed? Add Eclipse(?) files to your .gitignore.

 

[MinerdanJuan]

Even if you set it so the broadcast message is for a group called "Legend" and you have the group legend it will still say None ??[DOUBLEPOST=1492432438][/DOUBLEPOST]+ I had to manually create the config.yml and the directory

 

[jackskate]

Seems pretty sick! Gunna give it a try!

 

[Samuel]

Yo could you review my code?

Do you have a thread? I'm bored so fuck it why not