(Essential HCF Plugin)
- Thread starter Phasinq
- Start date
- Status
PebbleHost
High performance, consistent uptime and fast support. Minecraft hosting that just works.
Should be free.
Hey, just looked over the plugin and found some interesting things:
Not trying to be rude, just giving out criticism, something I really wished someone would do for me when I just started out. If you have any questions go ahead and pm me and I will help you.
- You seemed to use improper conventions, especially when using the clearchat method, it would be a lot cleaner if you used an For Statement like you utilized throughout other classes.
- Why are you grabbing the instance when the player doesn't have a permission for a command? I would personally grab the instance in the constructor you made at the top of all of your classes.
- For declaring statements whether the server is frozen or not should just simply be done with a boolean, there is no point doing an enumerator, considering frozen is either 2 values, true for frozen and false for not. Although if you were going to use an enumerator for some odd reason I would create a whole new class utilizing an enumerator, and using getters and setters would really clean it up. Try and lookup how to use lombok, it will really clean up your code.
- Your packages don't follow proper Java conventions.
- You should declare the instance = null as the server runs the onDisable method, it's not very important but it does prevent some memory leaks.
- Your plugin has a option to see a servers Teamspeak and store but it doesn't enable an option to configure what the message says?
Not trying to be rude, just giving out criticism, something I really wished someone would do for me when I just started out. If you have any questions go ahead and pm me and I will help you.
Last edited:
Thanks for the response, I am a new developer and I'm not really that professional, But I did release this for free for that reason, I just want people to use my plugin and try to help them.
I will take in consideration as to everything you said, And I will add a config to this plugin, The reason the plugin doesn't have a config with it is because I wanted to sell this plugin but then decided to release it to the plugin, Thanks for the response, Will try to fix everything you have stated as to adding a config for the further releases.
-Phasinq//Unscheduled.
I will take in consideration as to everything you said, And I will add a config to this plugin, The reason the plugin doesn't have a config with it is because I wanted to sell this plugin but then decided to release it to the plugin, Thanks for the response, Will try to fix everything you have stated as to adding a config for the further releases.
-Phasinq//Unscheduled.
Banned forever. Reason: Creating Multiple Accounts (Unscheduled)
That's what I like to hear, please let me know if you have any questions on anything that I critiqued. I'm glad to help
- Status
