Help

[felldownstairs]

Hello there,
I found use of a really good scoreboard tutorial and began to use it

I would really like it if someone could help me with the following:

I would like to display something on there saying Vanished: True if they are vanished or Vanished: False if they are not. Whenever I get my arraylist from another class however, it does not display on the scorebaord and just spams errors, in the this.sb.addLine(11, whatever) section. Please could someone help me fix this and possibly give me some code to help.

Also, I would like to get a sotw showing on the board. so when a player executes a certain command, something will countdown from 2 hours on the scoreboard and when it gets to 0 then it go's off the scoreboard.

thanks

 

[felldownstairs]

Post a screenshot of the errors.

thats the errors i been getting in console whenever a player is on

 

[KingWampy]

Code?

 

[felldownstairs]

Code?

vanish command class:
package commands;

import java.util.ArrayList;

import org.bukkit.Bukkit;
import org.bukkit.ChatColor;
import org.bukkit.command.Command;
import org.bukkit.command.CommandExecutor;
import org.bukkit.command.CommandSender;
import org.bukkit.entity.Player;

import me.p3i.vanishscoreboard.MainClass;
import me.p3i.vanishscoreboard.SPlayer;

public class VanishCommand implements CommandExecutor {

private static VanishCommand instance;

public void onEnable() {
instance = this;
}

public static VanishCommand getInstance() {
return instance;
}


public ArrayList<Player> vanished = new ArrayList<Player>();

public boolean onCommand(CommandSender sender, Command cmd, String label, String[] args) {
Player p = (Player) sender;
if(cmd.getName().equalsIgnoreCase("vanish") || cmd.getName().equalsIgnoreCase("v")) {
if(!p.hasPermission("hcf.command.vanish")) {
p.sendMessage(ChatColor.translateAlternateColorCodes('&', MainClass.getInstance().config.getString("noperm-message")));
return false;
}
for (Player o : Bukkit.getOnlinePlayers()) {
if(vanished.contains(p)) {
vanished.remove(p);
p.sendMessage(ChatColor.translateAlternateColorCodes('&', MainClass.getInstance().config.getString("vanish-disabled")));
p.showPlayer(o);
return false;
}
if(!vanished.contains(p)) {
vanished.add(p);
p.sendMessage(ChatColor.translateAlternateColorCodes('&', MainClass.getInstance().config.getString("vanish-enabled")));
p.hidePlayer(o);
return false;
}
}
}
return true;
}

}

scoreboard class:
package me.p3i.vanishscoreboard;

import java.util.ArrayList;

import org.bukkit.Bukkit;
import org.bukkit.Statistic;
import org.bukkit.entity.Player;
import org.bukkit.scoreboard.DisplaySlot;

import commands.SOTWCommand;
import commands.VanishCommand;
import net.md_5.bungee.api.ChatColor;

public class SPlayer {

private static SPlayer instance;

private VanishCommand vanishlist;

public void onEnable() {
instance = this;
}

public static SPlayer getInstance() {
return instance;
}

private static MainClass plugin = MainClass.getPlugin(MainClass.class);

private String player;
public ScoreB sb;

public SPlayer(String player) {
this.player = player;
this.sb = new ScoreB();
this.sb.setSlot(DisplaySlot.SIDEBAR);
this.sb.setName(ChatColor.translateAlternateColorCodes('&', MainClass.getInstance().config.getString("scoreboard-title")));
this.sb.addLine(15, ChatColor.translateAlternateColorCodes('&', MainClass.getInstance().config.getString("scoreboard-lines")));
this.sb.addLine(14, ChatColor.translateAlternateColorCodes('&', MainClass.getInstance().config.getString("online") + Bukkit.getOnlinePlayers().length));
this.sb.addLine(13, ChatColor.translateAlternateColorCodes('&', MainClass.getInstance().config.getString("kills") + "0"));
this.sb.addLine(12, ChatColor.translateAlternateColorCodes('&', MainClass.getInstance().config.getString("deaths") + "0"));
this.sb.addLine(11, ChatColor.translateAlternateColorCodes('&', MainClass.getInstance().config.getString("gamemode")));
this.sb.addLine(10, ChatColor.translateAlternateColorCodes('&', MainClass.getInstance().config.getString("vanished")));
this.sb.addLine(9, ChatColor.translateAlternateColorCodes('&', MainClass.getInstance().config.getString("scoreboard-lines")));
}



public synchronized void updateScoreboard() {
if(!(sb.hasBoard(getPlayer()))) {
sb.setForPlayer(getPlayer());
}
this.sb.updateLine(13, ChatColor.translateAlternateColorCodes('&', MainClass.getInstance().config.getString("kills") + getPlayer().getStatistic(Statistic.PLAYER_KILLS)));
this.sb.updateLine(12, ChatColor.translateAlternateColorCodes('&', MainClass.getInstance().config.getString("deaths") + getPlayer().getStatistic(Statistic.DEATHS)));

this.sb.updateLine(11, ChatColor.translateAlternateColorCodes('&', MainClass.getInstance().config.getString("gamemode") + getPlayer().getGameMode().toString().toLowerCase()));

if(vanishlist.vanished.contains(getPlayer())) {
this.sb.getLine(10).endsWith(ChatColor.WHITE + "True");
}
if(!vanishlist.vanished.contains(getPlayer())) {
this.sb.getLine(10).endsWith(ChatColor.WHITE + "False");
}
}

public Player getPlayer() {
return Bukkit.getPlayer(this.player);
}


}


whenever i try to get the arraylist from the vanish command thing to make the if(vanishlist.vanished.contains(p)) lines it always displays the scoreboard as the sb.addLine line and spams the console with what i put in my previous reply.

 

[KingWampy]

First off, this is not how you should post code. Secondly, the error is an NPE, so my guess would be that you aren't setting the player variable correctly. Thirdly, don't use

Bukkit.getPlayer()

use I think

getServer().getOfflinePlayer().getPlayer()

Follow the parameters in the Javadoc for that.

 

[felldownstairs]

In your VanishCommand class, you are casting CommandSender to Player without checking if the sender is player. You should do this:

if (sender instanceof Player) {
    //do your stuff
}

Also you did p.hidePlayer(o), which means hiding the online player from the player. And all online players can still see the player. Fix:

for (Player o : Bukkit.getOnlinePlayers()) {
    o.hidePlayer(p);
}

In your SPlayer class, you are using a String field for the player. You should use Player instead.

private Player player;

Getter: (I recommend you use Lombok)

public Player getPlayer() {
    return player
}

And about the error, its from your updateScoreboard method. Maybe some paths are missing in the config.yml or your config field is not setup in your Main class.

could i use the if (o.cansee) thingy whatever it is (forgot it lol)

 

[felldownstairs]

You mean this?

for (Player o : Bukkit.getOnlinePlayers()) {
    if (o.canSee(p)) {
        o.hidePlayer(p);
    }
}

yes but could i also use if (o.canSee(p)) {
}
in my scoreboard to set the true and false?

 

[felldownstairs]

You should do this:

boolean vanished = VanishCommand.getInstance().vanished.contains(player);

Also you should store UUIDs instead of players in the vanished list.

thanks, also how would i make a 2 hour sotw timer?

 

[felldownstairs]

I won't teach you everything lol. Considering this is your core.

it wont be everything xD just need to know how to start a timer in a seperate core, turn it into an int or string, and display it on the scoreboard

 

[felldownstairs]

You should do this:

boolean vanished = VanishCommand.getInstance().vanished.contains(player);

Also you should store UUIDs instead of players in the vanished list.

also, quickly, how tf do i even use that?

 

[felldownstairs]

You should add a line to your scoreboard like this:

"Vanished: " + (vanished ? "true" : "false");

You clearly doesn't know what are you doing tbh.
Why are you even trying to make a core?

cant you just add everything you said to the SPlayer class and just give it to me

 

[felldownstairs]

You should add a line to your scoreboard like this:

"Vanished: " + (vanished ? "true" : "false");

You clearly doesn't know what are you doing tbh.
Why are you even trying to make a core?

doesnt work, the boolean vanished... line fucks up my whole scoreboard

 

[felldownstairs]

wdym?

i added in the boolean vanished = etc. thing under private String player; and now when i load it up with the vanished + true ? false thing it gives me an error in the join event which directs to the boolean vanished = etc. thing

 

[felldownstairs]

Screenshot of errors again.

 

[felldownstairs]

scoreboard:
package me.p3i.vanishscoreboard;

import java.util.ArrayList;

import org.bukkit.Bukkit;
import org.bukkit.GameMode;
import org.bukkit.Statistic;
import org.bukkit.entity.Player;
import org.bukkit.scoreboard.DisplaySlot;

import commands.SOTWCommand;
import commands.VanishCommand;
import net.md_5.bungee.api.ChatColor;

public class SPlayer {

private static SPlayer instance;

private VanishCommand vanishlist;

public void onEnable() {
instance = this;
}

public static SPlayer getInstance() {
return instance;
}

private static MainClass plugin = MainClass.getPlugin(MainClass.class);

private String player;
boolean vanished = VanishCommand.getInstance().vanished.contains(player);
public ScoreB sb;

public SPlayer(String player) {
this.player = player;
this.sb = new ScoreB();
this.sb.setSlot(DisplaySlot.SIDEBAR);
this.sb.setName(ChatColor.translateAlternateColorCodes('&', MainClass.getInstance().config.getString("scoreboard-title")));
this.sb.addLine(15, ChatColor.translateAlternateColorCodes('&', MainClass.getInstance().config.getString("scoreboard-lines")));
this.sb.addLine(14, ChatColor.translateAlternateColorCodes('&', MainClass.getInstance().config.getString("online") + Bukkit.getOnlinePlayers().length));
this.sb.addLine(13, ChatColor.translateAlternateColorCodes('&', MainClass.getInstance().config.getString("kills") + "0"));
this.sb.addLine(12, ChatColor.translateAlternateColorCodes('&', MainClass.getInstance().config.getString("deaths") + "0"));
this.sb.addLine(11, ChatColor.translateAlternateColorCodes('&', MainClass.getInstance().config.getString("gamemode")));
this.sb.addLine(10, ChatColor.translateAlternateColorCodes('&', MainClass.getInstance().config.getString("vanished") + (vanished ? "true" : "false")));
this.sb.addLine(9, ChatColor.translateAlternateColorCodes('&', MainClass.getInstance().config.getString("scoreboard-lines")));
}



public synchronized void updateScoreboard() {
if(!(sb.hasBoard(getPlayer()))) {
sb.setForPlayer(getPlayer());
}
this.sb.updateLine(13, ChatColor.translateAlternateColorCodes('&', MainClass.getInstance().config.getString("kills") + getPlayer().getStatistic(Statistic.PLAYER_KILLS)));
this.sb.updateLine(12, ChatColor.translateAlternateColorCodes('&', MainClass.getInstance().config.getString("deaths") + getPlayer().getStatistic(Statistic.DEATHS)));

if(getPlayer().getGameMode() == GameMode.SURVIVAL) {
this.sb.updateLine(11, ChatColor.translateAlternateColorCodes('&', MainClass.getInstance().config.getString("gamemode") + ChatColor.translateAlternateColorCodes('&', MainClass.getInstance().config.getString("scoreboard-creative"))));
}
if(getPlayer().getGameMode() == GameMode.CREATIVE) {
this.sb.updateLine(11, ChatColor.translateAlternateColorCodes('&', MainClass.getInstance().config.getString("gamemode") + ChatColor.translateAlternateColorCodes('&', MainClass.getInstance().config.getString("scoreboard-survival"))));
}

}
public Player getPlayer() {
return Bukkit.getPlayer(this.player);
}


}

playerlistener (where the playerjoinevent is)
package me.p3i.vanishscoreboard;

import org.bukkit.Bukkit;
import org.bukkit.event.EventHandler;
import org.bukkit.event.EventPriority;
import org.bukkit.event.Listener;
import org.bukkit.event.player.PlayerChangedWorldEvent;
import org.bukkit.event.player.PlayerJoinEvent;
import org.bukkit.event.player.PlayerKickEvent;
import org.bukkit.event.player.PlayerQuitEvent;

public class PlayerListener implements Listener {

@EventHandler(priority = EventPriority.HIGH)
public void onJoin(PlayerJoinEvent e) {
SManager.getPlayers().put(e.getPlayer().getUniqueId(), new SPlayer(e.getPlayer().getName()));
}

@EventHandler(priority = EventPriority.HIGH)
public void onPlayerChangeWorld(PlayerChangedWorldEvent e) {
e.getPlayer().setScoreboard(Bukkit.getScoreboardManager().getNewScoreboard());
}

@EventHandler(priority = EventPriority.HIGH)
public void onKick(PlayerKickEvent e) {
SManager.getPlayers().remove(e.getPlayer().getUniqueId());
}

@EventHandler(priority = EventPriority.HIGH)
public void onQuit(PlayerQuitEvent e) {
SManager.getPlayers().remove(e.getPlayer().getUniqueId());
}


}

 

[felldownstairs]

here:

package me.p3i.vanishscoreboard;

import java.util.ArrayList;

import org.bukkit.Bukkit;
import org.bukkit.GameMode;
import org.bukkit.Statistic;
import org.bukkit.entity.Player;
import org.bukkit.scoreboard.DisplaySlot;

import commands.SOTWCommand;
import commands.VanishCommand;
import net.md_5.bungee.api.ChatColor;

public class SPlayer {

    private static final MainClass plugin = MainClass.getPlugin(MainClass.class);
    private static SPlayer instance;
    private final Player player;
    public ScoreB sb;
    private final VanishCommand vanishCommand = VanishCommand.getInstance();

    public SPlayer(Player player) {
        instance = this;
        this.player = player;
        sb = new ScoreB();
        sb.setSlot(DisplaySlot.SIDEBAR);
        sb.setName(ChatColor.translateAlternateColorCodes('&', MainClass.getInstance().config.getString("scoreboard-title")));
        sb.addLine(15, ChatColor.translateAlternateColorCodes('&', MainClass.getInstance().config.getString("scoreboard-lines")));
        sb.addLine(14, ChatColor.translateAlternateColorCodes('&', MainClass.getInstance().config.getString("online")) + Bukkit.getOnlinePlayers().length);
        sb.addLine(13, ChatColor.translateAlternateColorCodes('&', MainClass.getInstance().config.getString("kills")) + "0");
        sb.addLine(12, ChatColor.translateAlternateColorCodes('&', MainClass.getInstance().config.getString("deaths"))+ "0");
        sb.addLine(11, ChatColor.translateAlternateColorCodes('&', MainClass.getInstance().config.getString("gamemode")));
        boolean vanished = vanishCommand.vanished.contains(player);
        sb.addLine(10, ChatColor.translateAlternateColorCodes('&', MainClass.getInstance().config.getString("vanished")) + (vanished ? "true" : "false"));
        sb.addLine(9, ChatColor.translateAlternateColorCodes('&', MainClass.getInstance().config.getString("scoreboard-lines")));
    }

    public synchronized void updateScoreboard() {
        if(!(sb.hasBoard(player))) {
            sb.setForPlayer(player);
        }
        sb.updateLine(13, ChatColor.translateAlternateColorCodes('&', MainClass.getInstance().config.getString("kills") + player.getStatistic(Statistic.PLAYER_KILLS)));
        sb.updateLine(12, ChatColor.translateAlternateColorCodes('&', MainClass.getInstance().config.getString("deaths") + player.getStatistic(Statistic.DEATHS)));
        GameMode gameMode = player.getGameMode();
        if(gameMode == GameMode.SURVIVAL) {
            sb.updateLine(11, ChatColor.translateAlternateColorCodes('&', MainClass.getInstance().config.getString("gamemode") + ChatColor.translateAlternateColorCodes('&', MainClass.getInstance().config.getString("scoreboard-creative"))));
        }
        else if (gameMode == GameMode.CREATIVE) {
            sb.updateLine(11, ChatColor.translateAlternateColorCodes('&', MainClass.getInstance().config.getString("gamemode") + ChatColor.translateAlternateColorCodes('&', MainClass.getInstance().config.getString("scoreboard-survival"))));
        }
        boolean vanished = vanishCommand.vanished.contains(player);
        sb.updateLine(10, ChatColor.translateAlternateColorCodes('&', MainClass.getInstance().config.getString("vanished")) + (vanished ? "true" : "false"));

    }

    public static SPlayer getInstance() {
        return instance;
    }

    public Player getPlayer() {
        return player;
    }
}

thank you so much, ill try it out later[DOUBLEPOST=1501196860][/DOUBLEPOST]

here:

package me.p3i.vanishscoreboard;

import java.util.ArrayList;

import org.bukkit.Bukkit;
import org.bukkit.GameMode;
import org.bukkit.Statistic;
import org.bukkit.entity.Player;
import org.bukkit.scoreboard.DisplaySlot;

import commands.SOTWCommand;
import commands.VanishCommand;
import net.md_5.bungee.api.ChatColor;

public class SPlayer {

    private static final MainClass plugin = MainClass.getPlugin(MainClass.class);
    private static SPlayer instance;
    private final Player player;
    public ScoreB sb;
    private final VanishCommand vanishCommand = VanishCommand.getInstance();

    public SPlayer(Player player) {
        instance = this;
        this.player = player;
        sb = new ScoreB();
        sb.setSlot(DisplaySlot.SIDEBAR);
        sb.setName(ChatColor.translateAlternateColorCodes('&', MainClass.getInstance().config.getString("scoreboard-title")));
        sb.addLine(15, ChatColor.translateAlternateColorCodes('&', MainClass.getInstance().config.getString("scoreboard-lines")));
        sb.addLine(14, ChatColor.translateAlternateColorCodes('&', MainClass.getInstance().config.getString("online")) + Bukkit.getOnlinePlayers().length);
        sb.addLine(13, ChatColor.translateAlternateColorCodes('&', MainClass.getInstance().config.getString("kills")) + "0");
        sb.addLine(12, ChatColor.translateAlternateColorCodes('&', MainClass.getInstance().config.getString("deaths"))+ "0");
        sb.addLine(11, ChatColor.translateAlternateColorCodes('&', MainClass.getInstance().config.getString("gamemode")));
        boolean vanished = vanishCommand.vanished.contains(player);
        sb.addLine(10, ChatColor.translateAlternateColorCodes('&', MainClass.getInstance().config.getString("vanished")) + (vanished ? "true" : "false"));
        sb.addLine(9, ChatColor.translateAlternateColorCodes('&', MainClass.getInstance().config.getString("scoreboard-lines")));
    }

    public void updateScoreboard() {
        if (!(sb.hasBoard(player))) {
            sb.setForPlayer(player);
        }
        sb.updateLine(13, ChatColor.translateAlternateColorCodes('&', MainClass.getInstance().config.getString("kills") + player.getStatistic(Statistic.PLAYER_KILLS)));
        sb.updateLine(12, ChatColor.translateAlternateColorCodes('&', MainClass.getInstance().config.getString("deaths") + player.getStatistic(Statistic.DEATHS)));
        GameMode gameMode = player.getGameMode();
        if (gameMode == GameMode.SURVIVAL) {
            sb.updateLine(11, ChatColor.translateAlternateColorCodes('&', MainClass.getInstance().config.getString("gamemode") + ChatColor.translateAlternateColorCodes('&', MainClass.getInstance().config.getString("scoreboard-creative"))));
        }
        else if (gameMode == GameMode.CREATIVE) {
            sb.updateLine(11, ChatColor.translateAlternateColorCodes('&', MainClass.getInstance().config.getString("gamemode") + ChatColor.translateAlternateColorCodes('&', MainClass.getInstance().config.getString("scoreboard-survival"))));
        }
        boolean vanished = vanishCommand.vanished.contains(player);
        sb.updateLine(10, ChatColor.translateAlternateColorCodes('&', MainClass.getInstance().config.getString("vanished")) + (vanished ? "true" : "false"));

    }

    public static SPlayer getInstance() {
        return instance;
    }

    public Player getPlayer() {
        return player;
    }
}

wait, im now getting errors in my other classes for new SPlayer(e.getPlayer().getName()));

and new SPlayer(player.getName()));[DOUBLEPOST=1501196972][/DOUBLEPOST]

it says that for both of them[DOUBLEPOST=1501198457][/DOUBLEPOST]

here:

package me.p3i.vanishscoreboard;

import java.util.ArrayList;

import org.bukkit.Bukkit;
import org.bukkit.GameMode;
import org.bukkit.Statistic;
import org.bukkit.entity.Player;
import org.bukkit.scoreboard.DisplaySlot;

import commands.SOTWCommand;
import commands.VanishCommand;
import net.md_5.bungee.api.ChatColor;

public class SPlayer {

    private static final MainClass plugin = MainClass.getPlugin(MainClass.class);
    private static SPlayer instance;
    private final Player player;
    public ScoreB sb;
    private final VanishCommand vanishCommand = VanishCommand.getInstance();

    public SPlayer(Player player) {
        instance = this;
        this.player = player;
        sb = new ScoreB();
        sb.setSlot(DisplaySlot.SIDEBAR);
        sb.setName(ChatColor.translateAlternateColorCodes('&', MainClass.getInstance().config.getString("scoreboard-title")));
        sb.addLine(15, ChatColor.translateAlternateColorCodes('&', MainClass.getInstance().config.getString("scoreboard-lines")));
        sb.addLine(14, ChatColor.translateAlternateColorCodes('&', MainClass.getInstance().config.getString("online")) + Bukkit.getOnlinePlayers().length);
        sb.addLine(13, ChatColor.translateAlternateColorCodes('&', MainClass.getInstance().config.getString("kills")) + "0");
        sb.addLine(12, ChatColor.translateAlternateColorCodes('&', MainClass.getInstance().config.getString("deaths"))+ "0");
        sb.addLine(11, ChatColor.translateAlternateColorCodes('&', MainClass.getInstance().config.getString("gamemode")));
        boolean vanished = vanishCommand.vanished.contains(player);
        sb.addLine(10, ChatColor.translateAlternateColorCodes('&', MainClass.getInstance().config.getString("vanished")) + (vanished ? "true" : "false"));
        sb.addLine(9, ChatColor.translateAlternateColorCodes('&', MainClass.getInstance().config.getString("scoreboard-lines")));
    }

    public void updateScoreboard() {
        if (!(sb.hasBoard(player))) {
            sb.setForPlayer(player);
        }
        sb.updateLine(13, ChatColor.translateAlternateColorCodes('&', MainClass.getInstance().config.getString("kills") + player.getStatistic(Statistic.PLAYER_KILLS)));
        sb.updateLine(12, ChatColor.translateAlternateColorCodes('&', MainClass.getInstance().config.getString("deaths") + player.getStatistic(Statistic.DEATHS)));
        GameMode gameMode = player.getGameMode();
        if (gameMode == GameMode.SURVIVAL) {
            sb.updateLine(11, ChatColor.translateAlternateColorCodes('&', MainClass.getInstance().config.getString("gamemode") + ChatColor.translateAlternateColorCodes('&', MainClass.getInstance().config.getString("scoreboard-creative"))));
        }
        else if (gameMode == GameMode.CREATIVE) {
            sb.updateLine(11, ChatColor.translateAlternateColorCodes('&', MainClass.getInstance().config.getString("gamemode") + ChatColor.translateAlternateColorCodes('&', MainClass.getInstance().config.getString("scoreboard-survival"))));
        }
        boolean vanished = vanishCommand.vanished.contains(player);
        sb.updateLine(10, ChatColor.translateAlternateColorCodes('&', MainClass.getInstance().config.getString("vanished")) + (vanished ? "true" : "false"));

    }

    public static SPlayer getInstance() {
        return instance;
    }

    public Player getPlayer() {
        return player;
    }
}

so i fixed the errors, but im still getting an issue with boolean vanished = vanishCommand.vanished.contains(player);

 

[felldownstairs]

Im about to kms.

new SPlayer(player)

i did that to fix those errors, but i still got an error with boolean vanished = vanishCommand.vanished.contains(player);