how much of a skid am I
- Thread starter Turtle
- Start date
- Status
PebbleHost
High performance, consistent uptime and fast support. Minecraft hosting that just works.
go away n00b!!10/10 skid, would skid again.
no but I have no idea, i'm not a developer, or am I?
2 Skid Rating.
Those commit messages... And look at your plugin.yml on Github, you are not using the correct encoding type. Also you realise there is a releases feature in github, which is where you should put your compiled jar. Your README has no latest version specified.
Also I suggest learning Maven, extremely helpful and a good skill to posses. Good luck and keep up the good work!
Those commit messages... And look at your plugin.yml on Github, you are not using the correct encoding type. Also you realise there is a releases feature in github, which is where you should put your compiled jar. Your README has no latest version specified.
Also I suggest learning Maven, extremely helpful and a good skill to posses. Good luck and keep up the good work!
its all good
in announce command u could do switch (make subcmd lowercase) instead of a bunch of if statements
rest looks good i think not enough to rly judge off though
sendInvalidMessage() inside that class should be private not public
in announce command u could do switch (make subcmd lowercase) instead of a bunch of if statements
rest looks good i think not enough to rly judge off though
sendInvalidMessage() inside that class should be private not public
Why lombok. It's a bad habbit. Professional environments barely accept Lombok and it is incredibly hard to read. It's simply not clean. It's not sufficient nor great to maintain.
You seem to abuse how many line-spaces you have. You separate function code which is good, but you have unnecessary lines.
Rather than setting things up in a constructor, have a private method to set the variable values. It makes code cleaner.
Your util class should be declared final. You should use ThreadLocalRandom rather than creating lots of random instances - it's a waste of resources. You should also load your colour and colour ids into a map and grab the information from the map. This map should be static and the values should be loaded when the static constructor is called.
You have no validation on the amount of messages in the configuration list. The task should not start if there's no values in the list. Validation is key. You should store a primitive value for the current broadcast id. This uses less resources than removing and adding the same value from and to the list.
You seem to abuse how many line-spaces you have. You separate function code which is good, but you have unnecessary lines.
Rather than setting things up in a constructor, have a private method to set the variable values. It makes code cleaner.
Your util class should be declared final. You should use ThreadLocalRandom rather than creating lots of random instances - it's a waste of resources. You should also load your colour and colour ids into a map and grab the information from the map. This map should be static and the values should be loaded when the static constructor is called.
You have no validation on the amount of messages in the configuration list. The task should not start if there's no values in the list. Validation is key. You should store a primitive value for the current broadcast id. This uses less resources than removing and adding the same value from and to the list.
thank you for real feedback. I'll take this into account for my next project[DOUBLEPOST=1500902938][/DOUBLEPOST]
Also, the util class is not my work. It is a class I found on spigot forums
Last edited:
Nonetheless it should still be cleaned up
- Status
