KP-PVP (The ultimate kitpvp plugin)

Status
This thread has been locked.
PebbleHost
High performance, consistent uptime and fast support. Minecraft hosting that just works.

Harry

Rustacean
Management
Feedback score
10
Posts
1,606
Reactions
876
Resources
0
I see that a lot of effort has gone into this plugin but the main thing I wanted to point out was how many static variables you're using.

From Main.java:
public static final String instance2 = null;
public static Object instancs;
public static Logger log;
public static File customizationf = new File("plugins/KP-PVP", "settings.yml");
public static Plugin plugin;
public static Main instance;
private static ConfigUtils cH;
public static File file_x1 = new File("plugins/KP-PVP", "1v1.yml");
public static FileConfiguration cfg_x1 = YamlConfiguration.loadConfiguration(file_x1);
public static FileConfiguration customization = YamlConfiguration.loadConfiguration(customizationf);

My best advice would be to pass the Main class as a parameter when you initialize other classes.
public class Logger {
public class Main {
@SuppressWarnings("unused")
private Logger logger = new Logger(this);

public void example() {
logger.logInfo("test");
}
}
public class Logger {
@SuppressWarnings("unused")
private Main instance;

public Logger(Main instance) {
this.instance = instance;
}

public void logInfo(String message) {

}
}
 
Status
This thread has been locked.
Top