[Open Source & FREE] DiscordEmbed -> Embed messages without a bot!
- Thread starter Ghast
- Start date
- Status
PebbleHost
High performance, consistent uptime and fast support. Minecraft hosting that just works.
Could you send a screenshot of the folder you downloaded in 'Releases'?[DOUBLEPOST=1566332187][/DOUBLEPOST]Link to download: https://github.com/GhastD/DiscordEmbeder/releases/download/1.0/Release.zip
Last edited:
Some friendly suggestions.....
Remove pointless comments like "Surround with an try statement to prevent errors from logging and crashing the software"
Reword comments like this "Transform the Json into a payload, specifying it's json", they are very confusing to read (this one specifically is also affected by second point)
Use better names, "HTTP" and "Json" are very vague
"public string MakeRequest(string url, string jsonContent)" should be static, then change
"
HTTP req = new HTTP();
req.MakeRequest(...);
"
to "HTTP.MakeRequest(...);"
Remove pointless comments like "Surround with an try statement to prevent errors from logging and crashing the software"
Reword comments like this "Transform the Json into a payload, specifying it's json", they are very confusing to read (this one specifically is also affected by second point)
Use better names, "HTTP" and "Json" are very vague
"public string MakeRequest(string url, string jsonContent)" should be static, then change
"
HTTP req = new HTTP();
req.MakeRequest(...);
"
to "HTTP.MakeRequest(...);"
Thank you for the suggestion! Will edit what you pointed out. As for the comments it's just to ease the reading for absolute beginners.
- Status
