[Open Source] Reports

[subbotted]

Making full thread soon.

Repo: https://github.com/subbotted/Reports
Compiled Version: https://www.dropbox.com/s/onmuul7yr4v5gl5/Reports.jar?dl=0

Dependencies etc on repo readme.



(Deleted old thread by request)

 

[Ritzzzez]

I would have deleted it too with all of the trash talking...

 

[subbotted]

Haven't read the code, but did you make the changes from the last thread? Not trying to hate, just wondering.

https://github.com/subbotted/Reports/commits/master

 

[tempaylol]

Vouch, the man

 

[qIooIp]

Class: ReportCommand.java

"Report report = new Report(target, player.getName(), reason);" should be below:

if(target == null) {
    player.sendMessage(Configuration.NOT_ONLINE.replaceAll("%player%", args[0]));
    return true;
}

 

[subbotted]

https://github.com/subbotted/Reports/blob/master/src/com/subbotted/util/Report.java#L20
https://github.com/subbotted/Reports/blob/master/src/com/subbotted/commands/ReportCommand.java#L38
You don't check if target is null or anything until AFTER you've created the object. Fix that

Yes sorry I didn't bug test the latest update, and the Report object wasn't used until one of the latest commits. Just committed a fix.

 

[Samuel]

INCONSISTENCIESSSSSSSSSSS
Fix 'em