PinPad / Passcode on doors

[Tuxie]

Hey guys,

I just finished this plugin and wanted to share with you all.
Let me know if you want new features or find bugs!

https://github.com/fabioglin/passcode-doors



Glad to help.
Cheers

 

[Dori]

Looks good. just so you know. When creating a variable there is no need to put super() if your class does not extend any other class. super() will do just nothing and take a bit computing time.

Example:

 

[Tuxie]

Agreed! That's just how Alt+shift+S - O in eclipse generate things and I usually don't delete it :rofl:

 

[Dori]

Agreed! That's just how Alt+shift+S - O in eclipse generate things and I usually don't delete it :rofl:

I am used to optimizing things so I had to point it out
Anyways, good job, it looks good!

 

[PTech]

Just a suggestion when you're utilizing DI in listeners, register the listener right then and there in the constructor using the newly initialized plugin instance, so when registering events just create the listener class object and you should be good to go!

Other than that, I'll look into this project more, some nerds here will talk about convention because that's the only thing they can critique.

Other than that, pretty good!(also try using set implementations instead of lists when you don't need indexes, they have faster adds and removes)