PLUGIN HELP NEEDED - GUI SAVING

Skionz · Mar 4, 2016

Crav said:

I am trying to make it so when I put an item into this gui it will be saved. Can someone tell me what I need to make it save when closed.

Code:

package com.etterman.crdonate;

import org.bukkit.Bukkit;
import org.bukkit.ChatColor;
import org.bukkit.Material;
import org.bukkit.command.Command;
import org.bukkit.command.CommandSender;
import org.bukkit.entity.Player;
import org.bukkit.event.EventHandler;
import org.bukkit.event.Listener;
import org.bukkit.event.block.Action;
import org.bukkit.event.player.PlayerInteractEvent;
import org.bukkit.inventory.Inventory;
import org.bukkit.inventory.ItemStack;
import org.bukkit.plugin.PluginManager;
import org.bukkit.plugin.java.JavaPlugin;

public class CRdonate extends JavaPlugin implements Listener {
  
    public void onEnable() {
        System.out.println("Turning on...");
      
        PluginManager pm = Bukkit.getServer().getPluginManager();
        pm.registerEvents(this, this);
    }

    @Override
    public boolean onCommand(CommandSender sender, Command command, String label, String[] args) {
        return true;
    }
  
    @EventHandler
    public void onPlayerInteract(PlayerInteractEvent e){
        Player p = e.getPlayer();
        ItemStack item = p.getItemInHand();
        if(e.getAction() == Action.RIGHT_CLICK_AIR || e.getAction() == Action.RIGHT_CLICK_BLOCK){
            if(item.getType() == Material.DIRT){
                Inventory inv = Bukkit.createInventory(null, 9 * 2, ChatColor.ITALIC + "Donations");
              
                p.openInventory(inv);
            }
        }
    }
}

Save the inventory in a field instead of creating a new one every time.

MJack · Mar 4, 2016

Code:

public class CRdonate extends JavaPlugin implements Listener {
  

  Inventory inv;
    public void onEnable() {
        System.out.println("Turning on...");
      
        PluginManager pm = Bukkit.getServer().getPluginManager();
        pm.registerEvents(this, this);
       inv = Bukkit.createInventory(null, 9 * 2, ChatColor.ITALIC + "Donations");
    }

    @Override
    public boolean onCommand(CommandSender sender, Command command, String label, String[] args) {
        return true;
    }
  
    @EventHandler
    public void onPlayerInteract(PlayerInteractEvent e){
        Player p = e.getPlayer();
        ItemStack item = p.getItemInHand();
        if(e.getAction() == Action.RIGHT_CLICK_AIR || e.getAction() == Action.RIGHT_CLICK_BLOCK){
            if(item.getType() == Material.DIRT){
                p.openInventory(inv);
            }
        }
    }
}

Try this instead.
We'll make the inventory once, in the onEnable rather than recreating it each time.

Jetterman · Mar 4, 2016

MJack said:

Code:

public class CRdonate extends JavaPlugin implements Listener {
 

  Inventory inv;
    public void onEnable() {
        System.out.println("Turning on...");
     
        PluginManager pm = Bukkit.getServer().getPluginManager();
        pm.registerEvents(this, this);
       inv = Bukkit.createInventory(null, 9 * 2, ChatColor.ITALIC + "Donations");
    }

    @Override
    public boolean onCommand(CommandSender sender, Command command, String label, String[] args) {
        return true;
    }
 
    @EventHandler
    public void onPlayerInteract(PlayerInteractEvent e){
        Player p = e.getPlayer();
        ItemStack item = p.getItemInHand();
        if(e.getAction() == Action.RIGHT_CLICK_AIR || e.getAction() == Action.RIGHT_CLICK_BLOCK){
            if(item.getType() == Material.DIRT){
                p.openInventory(inv);
            }
        }
    }
}

Try this instead.
We'll make the inventory once, in the onEnable rather than recreating it each time.

Thx worked.

Shattered · Mar 4, 2016

If you want it to save on a server restart you will have to make a config or something to store it in.

Skionz · Mar 4, 2016

MJack said:

Code:

public class CRdonate extends JavaPlugin implements Listener {
 

  Inventory inv;
    public void onEnable() {
        System.out.println("Turning on...");
     
        PluginManager pm = Bukkit.getServer().getPluginManager();
        pm.registerEvents(this, this);
       inv = Bukkit.createInventory(null, 9 * 2, ChatColor.ITALIC + "Donations");
    }

    @Override
    public boolean onCommand(CommandSender sender, Command command, String label, String[] args) {
        return true;
    }
 
    @EventHandler
    public void onPlayerInteract(PlayerInteractEvent e){
        Player p = e.getPlayer();
        ItemStack item = p.getItemInHand();
        if(e.getAction() == Action.RIGHT_CLICK_AIR || e.getAction() == Action.RIGHT_CLICK_BLOCK){
            if(item.getType() == Material.DIRT){
                p.openInventory(inv);
            }
        }
    }
}

Try this instead.
We'll make the inventory once, in the onEnable rather than recreating it each time.

If you're going to spoon-feed at least write quality code.

MJack · Mar 4, 2016

Skionz said:
If you're going to spoon-feed at least write quality code.

Sorry, was just trying to do it quickly.
In the future I won't just give it to them

7rory768 · Mar 4, 2016

Crav said:
System.out.println("Turning on...");

You shouldn't use System.out.println to log information, instead use this.getLogger().info("Turning on...");

Shattered · Mar 4, 2016

PlayerVaults uses YML, and I dont notice anything slow.

PLUGIN HELP NEEDED - GUI SAVING

Jetterman

Skionz

ogminecraft.com

MJack

Jetterman

Shattered

old-timer

Skionz

ogminecraft.com

MJack

7rory768

Shattered

old-timer