PPMF #2- Customisable Shockwave Tools w/out Dependancies
- Thread starter BladianMC
- Start date
- Status
PebbleHost
High performance, consistent uptime and fast support. Minecraft hosting that just works.
Not trying to trash your thread, but im pretty sure its “dependencies”. Otherwise, looks good.
Your code does not actually use a radius (this is a term for spheres/circles and yours creates a cube). Furthermore, I'm sure what most people assume when they see "radius" is that the block they break will be the centre. Yet your code makes it such that the centre is not the broken block, but rather the block they broke + ("radius"/2).
Having the block broken in fact facilitates everything else because you don't have to have different functions for block faces.
Also, some of the code is a bit random, like this:
Could be replaced with List<String> lore = Arrays.asList(split[3].split(":"));
Still, this is a very altruistic thing you're doing and is good
Having the block broken in fact facilitates everything else because you don't have to have different functions for block faces.
Also, some of the code is a bit random, like this:
Could be replaced with List<String> lore = Arrays.asList(split[3].split(":"));
Still, this is a very altruistic thing you're doing and is good
Your code does not actually use a radius (this is a term for spheres/circles and yours creates a cube). Furthermore, I'm sure what most people assume when they see "radius" is that the block they break will be the centre. Yet your code makes it such that the centre is not the broken block, but rather the block they broke + ("radius"/2).
Having the block broken in fact facilitates everything else because you don't have to have different functions for block faces.
Also, some of the code is a bit random, like this:
Could be replaced with List<String> lore = Arrays.asList(split[3].split(":"));
Still, this is a very altruistic thing you're doing and is good
Agreed with the list part, honestly just didn't think about it.
The radius part is me being shit at names, probably should just replace it by distance.
Now for the first argument I have one main problem, as you had stated I don't need to do the function with blockfaces but I believe this is incorrect.
(Unless I mis-read then in that case I'm completely incorrect)
The tool doesn't do a cube section, it does half a cube (well atleast close to half). The blockfaces are required so that the tool works relative to where the player is looking, and at the same does that half a cube the correct way, meaning not only going east, but going south.
I don't think there's a way of doing this without checking the block face of the broken block, otherwise what happens is that the half a cube won't go the correct direction at all times.
This is a really generous thing to do for this community, imo they don't deserve it. Keep up the good work
This is a really generous thing to do for this community, imo they don't deserve it. Keep up the good work
Thanks
Because they aren't required.
Bad habit is bad. I know, I need to get used to it.
- Status
