Rate my code.

[Foodle]

I usually don't do this, but i want other programmers of this site to criticize my code and tell me where I could improve. I want no flame wars(just try to keep out of insulting as in ~ "omfg are you dumb? x should be y"), I only want to expand my KNOWLEDGE.

Anyway, hack and slash:

https://github.com/FoodleProgedy/StaffModeUtil

 

[LCastr0]

please stop. first, it's not "just a second". using that method will never add up to a second. don't talk to down to me because you have no idea what you're talking about. i've read heavily into java optimization & the jvm bc i used to write (de)obfsucators/optimizers. if you're going to continue down this path about how using an ifNull method is going to add up time (or an entire second as you think :roflplease start linking articles & tests to back it up bc you're talking out of your ass.

thanks

I never said it was a second. You said it was a second. And I'm not "talking down to you".
Edit: I saw you wrote "a fraction of a second". My mistake, I'll fix my post.[DOUBLEPOST=1497216711][/DOUBLEPOST]Let me correct myself: I wanted to say that in SOME cases, when calling a method tons of times, it could take more time, which building up would cause a huge difference between calling and not calling the method. In THIS case, that does not happen. But in some cases, it could.
Btw, you could also use "assert" to check if it's null.

 

[badvibes]

I never said it was a second. You said it was a second. And I'm not "talking down to you".
Edit: I saw you wrote "a fraction of a second". My mistake, I'll fix my post.[DOUBLEPOST=1497216711][/DOUBLEPOST]Let me correct myself: I wanted to say that in SOME cases, when calling a method tons of times, it could take more time, which building up would cause a huge difference between calling and not calling the method. In THIS case, that does not happen. But in some cases, it could.
Btw, you could also use "assert" to check if it's null.

using the assert check would be stupid. assert is a debugging tool and shouldnt be in production code. for assert to even work you'd have to launch your software with whatever argument's needed to make it work. otherwise it won't do anything. this is a plugin so you wouldn't even be able to get assert to work.
and you're still wrong dude.. having that check inside the method as opposed to calling it makes no difference

 

[LCastr0]

Again, I said in that case, it doesn't matter much. But in other cases, there could be a big difference. And assert doesn't need anything to run... But you are correct, it shouldn't be used in production code.

 

[badvibes]

Again, I said in that case, it doesn't matter much. But in other cases, there could be a big difference. And assert doesn't need anything to run... But you are correct, it shouldn't be used in production code.

you have to use -enableassertions or -ea in order for assert to work. otherwise it's not going to work.