Redacted

Status
This thread has been locked.

GL

Java Developer
Banned
Feedback score
26
Posts
665
Reactions
330
Resources
0
Redacted
 
Last edited:
PebbleHost
High performance, consistent uptime and fast support. Minecraft hosting that just works.

manny

Developer
Supreme
Feedback score
12
Posts
501
Reactions
308
Resources
0
So I was working with this network, and after I finished their plugin they complained about the way permissionsex works with it's inheritance system (I was making them a free plugin anyway so they didn't scam me). So I decided since they don't want it i'll release it for free for people to use/skid. Not beautiful but if you're new to development you'll learn how to handle the keys of a configuration section and such. If you're not a developer I also linked a compiled version.

I'd recommend looking into GitHub as its well established towards open sourced and allows contributions from other creators

You should use MultiMap (guava) to allow multiple type of grants. You are also storing multiple types of maps for no reason you could use an object (e.g. Grant object) with it can have the name of the rank, duration and the appropriate target. Additionally, your listeners have several timers occuring open grants expiring which isn't needed and instead you an just run one timer onEnable or trigger on player join and quit if you want to avoid timers to figure whether it should expire or not

In your Utils you have your instance again which isn't needed. You should also look into getters and setters when working on related projects like this

You should look into more of the OOP of java for more knowledge towards what I'm referring towards.
 

manny

Developer
Supreme
Feedback score
12
Posts
501
Reactions
308
Resources
0
As stated previously, the code isn't the best. It's hard to make a good plugin whenever the person you're working with asks for it free and also decides to back out. This is a completely unfinished product. And the second instance is used for efficiency, so that I'm capable of typing much less when accessing the instance of the main class

Edit: I do plan to put it on GitHub but I haven't had time nor do I plan on maintaining this project, and secondly, I was told they wanted this plugin in three days so it's fairly rushed
It could take an hour to make this correctly and isn't something hard so I don't know why that an excuse and using an object would save more time then having several maps with all the same data. You also set timers for each players for every grant re-iterating over and over with each grant
 
Status
This thread has been locked.
Top