Vault - For Shops/Markets

[Justis]

What's vault?

Vault allows any plugin to interact with whatever chat/permissions/economy plugin the server has installed without knowing what chat/permissions/economy plugin the server has installed and directly supporting it. As long as both plugins support Vault, they both support each other.
​

I recently proposed to the maintainers of Vault that Shop/Market support be added, so that plugins like VoidChest, AutoFarm, SellHand, PickAxeSell, etc, etc, etc, can buy/sell items for the price set by the shop/market that the server is using.
This would ensure that the server owner doesn't have duplicate files specifying the prices for the items that they want to be transactable.
However, it is also absolutely necessary for my plugin, AutoEconomy, because the prices for items will automatically be changing, and so keeping prices in sync with AutoEconomy's market would be impossible without direct support for it.

My proposed interface was as follows:

Spoiler: Interface

import java.util.List;

import org.bukkit.OfflinePlayer;
import org.bukkit.inventory.ItemStack;

public interface Market {

    public boolean isEnabled();
    
    public String getName();
    
    public double buy(OfflinePlayer buyer, ItemStack item, int amt);
    
    public double buy(OfflinePlayer buyer, String label, int amt);
    
    public double sell(OfflinePlayer seller, ItemStack item, int amt);
    
    public double sell(OfflinePlayer seller, String label, int amt);

    public boolean hasMarketAccess(OfflinePlayer player);
    
    public boolean isDamagedItemSellingSupported(OfflinePlayer player);
    
    public List<ItemStack> getTransactableItems(OfflinePlayer player);
    
    public List<String> getTransactableLabels(OfflinePlayer player);
    
    public boolean isBuyable(OfflinePlayer player, ItemStack item);
    
    public boolean isBuyable(OfflinePlayer player, String label);
    
    public boolean isSellable(OfflinePlayer player, ItemStack item);
    
    public boolean isSellable(OfflinePlayer player, String label);
    
    public double getBuyPrice(OfflinePlayer player, ItemStack item, int amt);

    public double getBuyPrice(OfflinePlayer player, String label, int amt);
    
    public double getSellPrice(OfflinePlayer player, ItemStack item, int amt);
    
    public double getSellPrice(OfflinePlayer player, String label, int amt);
    
}

Unfortunately, my proposition was denied with the major reason being that it likely wouldn't end up being widely adopted, and the maintainers of Vault don't need the extra workload.

As they've suggested, and as I intended to do if the proposition was rejected, I'm going to be creating my own Vault-like plugin to serve the purposes I've described.

I will add implementation for all the major shop plugins, Essentials, ShopGUI+, Sign Shop, Boss Shop, Shop, Chest Shop, and of course AutoEconomy.

I have two questions for you, my fellow developers:

Would you use it?
And what should the project be called?

 

[Justis]

Project Vault.

Pretty sure that'd just get confused with Vault and thus have no identity of its own.

Imagine having Vault.jar installed on your server and then ProjectVault.jar both supporting completely different things.
A tad confusing, don't you think?

Probably not as I've already setup an API to get the prices from most of those plugins anyway, but...
Vault+ should suffice :tup:

That implies that the project would extend Vault, which I'm not doing, since it wouldn't be a fork, and I won't be constantly updating this project to package all of Vault's updates. They'll be two separate projects supporting different things.
Vault supporting chat and permissions and player economy. Mine supporting shops/markets.

 

[Ally]

100% would use it, so long as the project was open to developer contribution so people can add what they like, for widespread usage (little bit like vault), within reason.

And I think the name should be EcoBase or Economy Base or something along those lines. It would serve as the base of economy plugins, so that's why I think it'd be an appropriate name.

 

[Sparko]

VaultEco
EconoVault
PriceSync

 

[Blood]

InterMarket
EcoVault