Why isn't this code working [java]

[Hymart]

Maybe I just don't understand schedulers. But this is flashing an error message bruh and I can't diagnose that crap.

 

[Hymart]

Might be cause I'm casting the plugin to the plugin class.

 

[Ghast]

Dmed on discord.

 

[Kieraaaan]

Maybe I just don't understand schedulers. But this is flashing an error message bruh and I can't diagnose that crap.

Could you indent the code please? Press Control + Shift + F

 

[Hymart]

 

[Zyger]

Change active = true to active == true for starters

 

[Hymart]

Change active = true to active == true for starters

In this case it doesn't effect the functionality bruh[DOUBLEPOST=1560085077][/DOUBLEPOST]

Change active = true to active == true for starters

Actually, it breaks it entirely.

 

[Kieraaaan]

In this case it doesn't effect the functionality bruh[DOUBLEPOST=1560085077][/DOUBLEPOST]

Actually, it breaks it entirely.
View attachment 231102

This should work, you had some useless if statements so I removed them.

if (!(sender instanceof Player)) return true;
Player player = (Player) sender;
if (!player.hasPermission("timedflight.15m")) return true;
if (!active) {
    player.setAllowFlight(true);
    player.setFlying(true);
    player.sendMessage("asda");
    active = true;
    new BukkitRunnable() {
        @Override
        public void run() {
            player.setFlying(false);
            player.sendMessage("asda");
        }
    }.runTaskLater(plugin, 9000L);
} else {
    if (player.getAllowFlight()) {
        player.setAllowFlight(false);
        player.sendMessage("");
    }
}

EDIT: You shouldn't have a global boolean in the class because that can be changed by anyone. Use a HashMap<UUID, Boolean> to store the player's UUID and a boolean to see if they're flying or not.[DOUBLEPOST=1560085409][/DOUBLEPOST]

In this case it doesn't effect the functionality bruh[DOUBLEPOST=1560085077][/DOUBLEPOST]

Actually, it breaks it entirely.
View attachment 231102

He meant in the if statement, you had

if (active = true)

which you need to change to

if (active == true)

OR better, use

if (active)

 

[Hymart]

This should work, you had some useless if statements so I removed them.

if (!(sender instanceof Player)) return true;
Player player = (Player) sender;
if (!player.hasPermission("timedflight.15m")) return true;
if (!active) {
    player.setAllowFlight(true);
    player.setFlying(true);
    player.sendMessage("asda");
    active = true;
    new BukkitRunnable() {
        @Override
        public void run() {
            player.setFlying(false);
            player.sendMessage("asda");
        }
    }.runTaskLater(plugin, 9000L);
} else {
    if (player.getAllowFlight()) {
        player.setAllowFlight(false);
        player.sendMessage("");
    }
}

EDIT: You shouldn't have a global boolean in the class because that can be changed by anyone. Use a HashMap<UUID, Boolean> to store the player's UUID and a boolean to see if they're flying or not.[DOUBLEPOST=1560085409][/DOUBLEPOST]
He meant in the if statement, you had

if (active = true)

which you need to change to

if (active == true)

OR better, use

if (active)

That gives this error:

 

[Zyger]

Ghast ??

 

[Kieraaaan]

That gives this error:

yeah because you need to use your own plugin instance.

change plugin for this in the runnable bit.

 

[Hymart]

yeah because you need to use your own plugin instance.

change plugin for this in the runnable bit.

i'm an actual tool.

 

[Ghast]

Ghast ??

Thought you meant the variable oops.

 

[Kieraaaan]

i'm an actual tool.

https://docs.oracle.com/javase/tutorial/
Learn Java before coding with API's, it helps.

 

[Hymart]

https://docs.oracle.com/javase/tutorial/
Learn Java before coding with API's, it helps.

you think I have the effort or motivation to read through a million docs.

 

[Kieraaaan]

you think I have the effort or motivation to read through a million docs.

Well you're never going to learn by copying what other people write in YouTube tutorials.
Notice the word "copy". If you're not going to read through the docs and are going to watch YouTube videos, at least pause them and understand what the person is writing. Don't just copy or you won't learn anything.

 

[Zyger]

You should really work on your formatting, it'd make it a lot easier for you to diagnose things, and also include the line numbers if you're asking others for help with an error as well

 

[Hymart]

Well you're never going to learn by copying what other people write in YouTube tutorials.
Notice the word "copy". If you're not going to read through the docs and are going to watch YouTube videos, at least pause them and understand what the person is writing. Don't just copy or you won't learn anything.

trust me mate, if this monstrosity was from a tutorial I doubt it would be so defective and shitly laid out.

 

[GazpachoYT]

Line 32[DOUBLEPOST=1560086916][/DOUBLEPOST]Why are you doing if(active == true)? just change it to if(active) / if(!active)

 

[Kieraaaan]

Line 32[DOUBLEPOST=1560086916][/DOUBLEPOST]Why are you doing if(active == true)? just change it to if(active) / if(!active)

Umm, you just repeated what’s already been said :tup: nice one