eGrounds / UHCGrounds plugin

Status
This thread has been locked.

Meeran

Supreme
Feedback score
3
Posts
108
Reactions
35
Resources
0
Hello everyone :)

I am the owner of a AU Minecraft server, I had a dev help me called "thatkawaiisam" he threatened to leak our minigame so i did it myself, but now he is claiming its his plugin :p

-------
Plugin ran on a single server (1.5GB) with over 50 players.
Plugin is buggy!! Use as reference code my dudes :)
---

Github:
https://www.github.com/WabMiran/eGrounds
 
PebbleHost
High performance, consistent uptime and fast support. Minecraft hosting that just works.

Eric

Software Engineer
Supreme
Feedback score
14
Posts
1,760
Reactions
1,648
Resources
1
I'd also like to point out the fact that the code for this plugin is horrible

I'd do a more in depth analysis but I'm on my phone.
 

Eric

Software Engineer
Supreme
Feedback score
14
Posts
1,760
Reactions
1,648
Resources
1
I wasn't even talking about his code lol, I could care less. I was talking about you always being negative in every thread.
Focus on the point I was making? I'm not negative in every thread I comment on, there are just loads of dogshit threads around lately.
 

sammmmy

Supreme
Feedback score
9
Posts
65
Reactions
162
Resources
0
Focus on the point I was making? I'm not negative in every thread I comment on, there are just loads of dogshit threads around lately.

Would love to know what exactly is "disgusting code" in this, not trying to hate just want to know what to improve on.
 

Eric

Software Engineer
Supreme
Feedback score
14
Posts
1,760
Reactions
1,648
Resources
1
What about it gives you a headache?
From a quick minute of class surfing (not at all detailed):
- Capital package names
- trying to get the instance of the scoreboard handler without initialising it first
- holding players in a list[DOUBLEPOST=1501840267][/DOUBLEPOST]
https://github.com/WabMiran/eGrounds/blob/master/src/com/theeximusmc/egrounds/Core.java
This gives me a headache, Its 4:42am and i can't be getting a headache this late at night while i have clients to do plugins for right now.
Can't believe you didn't tell me when it was 420 dude
 

Eric

Software Engineer
Supreme
Feedback score
14
Posts
1,760
Reactions
1,648
Resources
1
https://github.com/WabMiran/eGrounds/blob/master/src/com/theeximusmc/egrounds/Commands/ArenaCMD.java
You literally used a switch statement to check an arg, copy and pasted this method to set the location when any "above average" developer who actually knows what tf they're talking about could have just made one simple method instead of copy and pasting shit around and giving the client shit code. You're the reason why my signature say what is says. This site is filled with all these new developers who are like 1 /12 months in and barely know wtf they're doing but have the audacity to charge someone for shit code.
Omg dude stop being so negative on threads!!1!
 

sammmmy

Supreme
Feedback score
9
Posts
65
Reactions
162
Resources
0
From a quick minute of class surfing (not at all detailed):
- Capital package names
- trying to get the instance of the scoreboard handler without initialising it first
- holding players in a list[DOUBLEPOST=1501840267][/DOUBLEPOST]
Can't believe you didn't tell me when it was 420 dude

1) That will be fixed once I upload to Github (Didn't know there were conventions with packages)
2) It is initialised isnt it???
3) Ok yes I will change that, is there actually any implications of doing it? I'm going to change it anyways, just curious.

https://github.com/WabMiran/eGrounds/blob/master/src/com/theeximusmc/egrounds/Commands/ArenaCMD.java
You literally used a switch statement to check an arg, copy and pasted this method to set the location when any "above average" developer who actually knows what tf they're talking about could have just made one simple method instead of copy and pasting shit around and giving the client shit code. You're the reason why my signature say what is says. This site is filled with all these new developers who are like 1 /12 months in and barely know wtf they're doing but have the audacity to charge someone for shit code.

1) Yes I know it is inefficient which is why I am open-sourcing it getting people to point out mistakes which I thank you guys for doing as it allows me to improve my code and learn from it.
 

sammmmy

Supreme
Feedback score
9
Posts
65
Reactions
162
Resources
0
You didn't know there were convention with packages, I'm done. You're a "dev" and didn't even think there were conventions on how you should name packages. I should't expect that much from a guy who is only 1 1/2 month in. I could care less on how your code look. You told asked me how your code was bad and i told you. I just have a problem when you guys sit here and sell your plugins on this platform when you barely know anything about coding. You just said you didn't even know there was conventions to follow when naming a package. You just proved my point.

Honestly didn't know...
 
Status
This thread has been locked.
Top