eGrounds / UHCGrounds plugin

[Meeran]

Hello everyone

I am the owner of a AU Minecraft server, I had a dev help me called "thatkawaiisam" he threatened to leak our minigame so i did it myself, but now he is claiming its his plugin

-------
Plugin ran on a single server (1.5GB) with over 50 players.
Plugin is buggy!! Use as reference code my dudes
---

Github:
https://www.github.com/WabMiran/eGrounds

 

[Eric]

1) That will be fixed once I upload to Github (Didn't know there were conventions with packages)
2) It is initialised isnt it???
3) Ok yes I will change that, is there actually any implications of doing it? I'm going to change it anyways, just curious.



1) Yes I know it is inefficient which is why I am open-sourcing it getting people to point out mistakes which I thank you guys for doing as it allows me to improve my code and learn from it.

Use UUIDs because accessing player instances can spring null pointers every time it is accessed unless you check, which is tedious as hell.

 

[sammmmy]

Use UUIDs because accessing player instances can spring null pointers every time it is accessed unless you check, which is tedious as hell.

Ok thanks! Actually good having someone on this website not being toxic and actually explaining something.

That's what happens when you watch the first 5 videos from pogostick and label yourself has a "Developer"

Um ok lol

 

[sammmmy]

Beat me to it.

Seeing capitals in the package names was the first red flag.

It's obvious that you have some form of knowledge in object oriented programming, however some of the logic you're using is questionable, there is also no inheritence from superclasses etc that should be fairly common in a plugin of this size.

It's not the worst I've seen at all, but it's not the best I've seen by a long shot, it just looks like he's currently in the process of learning.

I'd like to note that the programming style seems inconsistent, sammmmy did you code all of this? Or did you rip bits of code from other plugins?

I understand the capitals, when you say the logic is questionable could you provide an example just so I can note down. It is all my code just some from different projects at different stages from when I was learning. But otherwise thanks for the feedback!