Oh boy he's back again. Not denying there is a memory leak, but go ahead and point out a memory leak in ProPractice.
As for your GenBucket, I'm just going to critique one class, "xyz.rinn.genbucket.data.Generating.java".
1. You're using a static initializer block to instantiate the "active" map, when it could've been done in the line where it was declared.
Example:
could have beenCode:private static Map<UUID, GeneratingBlock> active; static { Generating.active = new HashMap<>(); }
Code:private static Map<UUID, GeneratingBlock> active = new HashMap<>();
2. You felt the need to declare the "active" map privately, when it's not needed. Doesn't really matter, but why private if it's not needed? You created more work for yourself.
3. Because of #2, you can't use the ALREADY PROVIDED methods of the HashMap outside of the Generating class. You improvised by "re-creating" the methods (you literally just took the data and used the HashMap's real methods). This is what I was talking about when I said you created more work for yourself. You could've just declared "active" publicly, and accessed the object from anywhere.
Looking at some of your other classes, you don't understand when to use final.
This doesn't really matter, but a lot of people prefer Google's Java Style. If you want to practice reusability, I would hope you would adapt to this. For example, after the end of each block or block-like structure, you use 2 line breaks, not 1... Just food for thought, you meme.
There is a difference between "every action" and something that is only done once every few minutes by each player. Some of the data you're storing should even be tied to the UUID of the player directly rather than a player such as the player's elo.
So you admit that you have/had memory leaks? You use the same excuse every time. "It's old", yeah right, cut the bullshit please. It was uploaded on GitHub 9 days ago, but as there were many versions of it, I'd assume it was started possibly a few months ago. I really don't care about any of this shit as long as you admit that your code is not as godly as you thing :3
You say that all the time yet you can't prove it. Anything you say, I easily counter. My code is not "garbage" and for sure a lot better than yours, lol.
Actually, there are no problems (or changes that should be made) with GenBucket. He was being delusional as he doesn't understand how modifiers, blocks, or memory management works. I admit, I had shitloads of problems with my code when I was at the level of this retard, but I never tried flexing on anyone, I just kept learning and working hard as I was able to acknowledge my lack of knowledge. Thanks for trying to back me up on this though, appreciate it
You don't make a variable public unless you have to... It's called encapsulation, go google it joeleoli.
public static float shipSpeed = 0;
public static float shipAcceleration = 0.1f;
public static float shipYaw = 0;
public static float shipPitch = 0;
public static float shipRoll = 0;
public static double lastForInput = 0;
public static double lastSideInput = 0;
public static float maxSpeed = 1;
public static float turnSpeed = 2;
public static float rollIncrement = 2;
public static float maxRoll = 35;
