- Status
How about instead of sucking off essentials, you should hook into vault and generate your own worth.yml, like ME.
Thanks for the constructive critism, I'll add this ASAP!
Going all out
Why is this plugin worth of $7.5 exactly? It looks like it could be coded in < a day. Not to mention the bad code in your code snippet.
1) Why don't you take advantage of Java 8 lambdas, much cleaner and more readable.
2. Why are you using singleton design pattern? This can be most always be replaced by Dependency Injection (which is actually better).
3. Why even bother wasting time collecting to a list if the stream itself has a .forEach() method?
wat
1) Why don't you take advantage of Java 8 lambdas, much cleaner and more readable.
2. Why are you using singleton design pattern? This can be most always be replaced by Dependency Injection (which is actually better).
3. Why even bother wasting time collecting to a list if the stream itself has a .forEach() method?
wat
Thanks for spotting the improvements possible in my code, I've changed it up. I feel like 7.50 dollars is fair because alot of server owners pay up to 50 dollars for a Void Chest plugin. Also BukkitRunables dont support lambdas expressions, I changed it to the scheduler just for youWhy is this plugin worth of $7.5 exactly? It looks like it could be coded in < a day. Not to mention the bad code in your code snippet.
1) Why don't you take advantage of Java 8 lambdas, much cleaner and more readable.
2. Why are you using singleton design pattern? This can be most always be replaced by Dependency Injection (which is actually better).
3. Why even bother wasting time collecting to a list if the stream itself has a .forEach() method?
wat
Last edited:
Yes you could choose to manually sell your items by putting them in the inventory opened when right clicking the voidchest. What most people will use this for is when using mob farms and run hoppers into the voidchest and the voidchest will sell those items and put that money into the balance of the faction owning that claim.
I dont see why he shouldn't use essentials worth.yml its less setup work, sure some servers don't have it then he should have it generate his own. The only other concern someone might have is they want the selling price via void chests be lower than just add a simple multiplier to the config so everything sold is 0.90 or something. (EDIT: he already has the multiplier so its already good enough...)
Also, this is open source in my plugin, yes there were dupes but they have been addressed (dont drop contents when the chest breaks, dont let anyone open a voidchest, etc.)
https://github.com/grrocks/Factions...ivecraft/factions/engine/EngineMain.java#L460 the main function is this.
Last edited:
Thanks for backing me up, I agree with you. The open-source looks good but I'm using an enderchest for my plugin just for looks
If you want I'll make you a Massivecraft version or any other faction plugin?
Sure thing, if you need anything customized or changed make sure to ask me! Im sure we can work something out.[DOUBLEPOST=1507069446][/DOUBLEPOST]
I've added the option for you to define your own price for items, I hope this will satify you.
Last edited:
Hey man could you fix the flight in your plugin? And are all the dupes patched?
Now if you added support for players rather than factions, for example whoever placed the void chest it will automatically go into the placers balance. Plus support for all mainstream factions version in one plugin is a good selling point. And you should maintain a hook into essentials worth.yml makes it alot easier for owners. Potentially consider adding hook into shopguiplus. With all this in mind $10.0 for this would be good for all that
Last edited:
I'll look into adding the player feature, the worth.yml will still work I've just added the option for you to specify prices in the config.yml.
- Status
