Free HCF (Link inside)

Status
This thread has been locked.
PebbleHost
High performance, consistent uptime and fast support. Minecraft hosting that just works.

Irantwomiles

Check my signature for a new Practice plugin
Premium
Feedback score
3
Posts
1,263
Reactions
570
Resources
0
Feel free to fork it while its public, good chance it'll be private after a couple hours. Don't expect this to be the greatest code you've ever seen.[DOUBLEPOST=1504327527][/DOUBLEPOST]Push #1 Coming soon. I had removed DTR all together for a customer, being added back. Also a much cleaner way of checking if a player left/entered a claim.[DOUBLEPOST=1504327793][/DOUBLEPOST]Also for anyone wondering. When I was making this plugin I completely forgot about needing a system faction, or just something that admins can control. It really wouldn't be hard to implement if you wanted to on this current code base, but I'm just not gonna worry about it.[DOUBLEPOST=1504328466][/DOUBLEPOST]Pushed the latest which should include DTR, and the new join/leave claim event. gonna sleep, give me any suggestions and I'll try to add them in.
 
Last edited:

Connectify

Supreme
Feedback score
5
Posts
86
Reactions
19
Resources
0
We need people like you in this community
 

Deleted User

Deactivated
Feedback score
18
Posts
218
Reactions
344
Resources
0
Briefly looked at the code, not so sure about some of it. For example basic naming conventions - you name your listeners "events".

Also, why do you create redundant YamlConfiguration objects, then statically load it afterwards? Here's what I mean:
Code:
new YamlConfiguration();

YamlConfiguration config = YamlConfiguration.loadConfiguration(file);

Anyway, good luck with your project.
 
Last edited:

Irantwomiles

Check my signature for a new Practice plugin
Premium
Feedback score
3
Posts
1,263
Reactions
570
Resources
0
Briefly looked at the code, not so sure about some of it. For example basic naming conventions - you name your listeners "events".

Also, why do you create redundant YamlConfiguration objects, then statically loading it afterwards? Here's what I mean:
Code:
new YamlConfiguration();

YamlConfiguration config = YamlConfiguration.loadConfiguration(file);

Anyway, good luck with your project.
Yea, the yaml thing is me being retarded and I havnt done that in a while. I'll fix it, thanks

EDIT: I did fix it, and I'm going to redo the naming conv and as someone else mentioned on the github I need to clean up the switch statement and probably move events that are relevant to each other in the same class.
 
Last edited:

kampai

Feedback score
8
Posts
361
Reactions
187
Resources
0
The code's a bit messy imo, but I was actually working on an hcf core, maybe I could help you on this?
 

Irantwomiles

Check my signature for a new Practice plugin
Premium
Feedback score
3
Posts
1,263
Reactions
570
Resources
0
If your looking for some help with this project or someone to help contribute on github please pm me i would be happy to work on this project with you :)
The code's a bit messy imo, but I was actually working on an hcf core, maybe I could help you on this?
You guys are welcome to work on it. You could just ask for a merge or something after you're done and I'll review it. Or you can make your own fork, doesn't matter to me.
 

Irantwomiles

Check my signature for a new Practice plugin
Premium
Feedback score
3
Posts
1,263
Reactions
570
Resources
0
Push coming very soon.

Removed the YamlConfiguration redundancy, thanks for letting me know Deleted User
Removed switch case statement for interaction in claim and replaced it with a config (MUCH cleaner, thanks to @Vertises on github)
Moved listeners that are related to each other in the same class
better naming conv[DOUBLEPOST=1504359776][/DOUBLEPOST]Started work on system factions cause why not.
 
Last edited:

zt

Alfie
Supreme
Feedback score
14
Posts
536
Reactions
172
Resources
0
yo dude can you tell me the spigot version or at least link it[DOUBLEPOST=1504458315][/DOUBLEPOST]and by the way that spigotmc link doesn't work it says error
 
Status
This thread has been locked.
Top