MineHQ Rank announcer

Status
This thread has been locked.

Capri

Well-Known Gangster
Supreme
Feedback score
6
Posts
133
Reactions
63
Resources
0
Last edited:
PebbleHost
High performance, consistent uptime and fast support. Minecraft hosting that just works.

Ritzzzez

Feedback score
0
Posts
83
Reactions
26
Resources
0
wow, talk about cluttered code...[DOUBLEPOST=1494427896][/DOUBLEPOST]Rather than Running a loop every time the timer goes off. Why not just make an onJoin and onQuit event adding/removing them from an ArrayList??[DOUBLEPOST=1494428020][/DOUBLEPOST]Also, you shouldn't declare minutes straight from config, rather checking if it is actually an integer and not null. I would check out naming and code style conventions if I were you.
 
Last edited:

subbotted

Contact on Discord, subbotted#5560
Supreme
Feedback score
17
Posts
524
Reactions
407
Resources
0
wow, talk about cluttered code...[DOUBLEPOST=1494427896][/DOUBLEPOST]Rather than Running a loop every time the timer goes off. Why not just make an onJoin and onQuit event adding/removing them from an ArrayList??[DOUBLEPOST=1494428020][/DOUBLEPOST]Also, you shouldn't declare minutes straight from config, rather checking if it is actually an integer and not null. I would check out naming and code style conventions if I were you.
with decently written code (Not saying mine is perfect)

Yes you have valid points but he said he knows it isn't perfect :D Give the guy a chance :)

EDIT: and I can't believe if your trying to roast his code that you didn't realise the package naming not following package conventions :D com.caprii.Core :/ (not roasting OP just saying <3)
 
Last edited:

Capri

Well-Known Gangster
Supreme
Feedback score
6
Posts
133
Reactions
63
Resources
0
wow, talk about cluttered code...[DOUBLEPOST=1494427896][/DOUBLEPOST]Rather than Running a loop every time the timer goes off. Why not just make an onJoin and onQuit event adding/removing them from an ArrayList??[DOUBLEPOST=1494428020][/DOUBLEPOST]Also, you shouldn't declare minutes straight from config, rather checking if it is actually an integer and not null. I would check out naming and code style conventions if I were you.

Thanks for the suggestions.

Yes you have valid points but he said he knows it isn't perfect :D Give the guy a chance :)

EDIT: and I can't believe if your trying to roast his code that you didn't realise the package naming not following package conventions :D com.caprii.Core :/ (not roasting OP just saying <3)
<3, what are package naming conventions?
 

Capri

Well-Known Gangster
Supreme
Feedback score
6
Posts
133
Reactions
63
Resources
0
When i click on the resource link it doesnt work
Yea they didn't accept the resource. I will change the link to mediafire or Dropbox when I get home today.
 

Ritzzzez

Feedback score
0
Posts
83
Reactions
26
Resources
0
I was not trying to roast that kid, rather than point out his mistakes.

PS. I did
his naming conventions and mentioned them, as you can see below and above.

Please don't try to call me out with that kind of grammar either... you're* realize*

EDIT: and I can't believe if your trying to roast his code that you didn't realise the package naming not following package conventions :D com.caprii.Core :/ (not roasting OP just saying <3)

I would check out naming and code style conventions if I were you.
 
Last edited:

subbotted

Contact on Discord, subbotted#5560
Supreme
Feedback score
17
Posts
524
Reactions
407
Resources
0
I was not trying to roast that kid, rather than point out his mistakes.

PS. I did
his naming conventions and mentioned them, as you can see below and above.

Please don't try to call me out with that kind of grammar either... you're* realize*

I wasn't calling you out? I was saying give the guy a chance and the way you 'pointed out his mistakes' seemed like you was roasting him/being a dick. And grammar? I'm from UK ;)

0c441817c1f9d09eec1814ff949a1172.png
 

Legitless_420

Feedback score
1
Posts
9
Reactions
2
Resources
0
Uhm, the plugin is cool Im gonna use it but, it announces a player that is OP, because he has all the permissions '-' how do I fix that?
 

Capri

Well-Known Gangster
Supreme
Feedback score
6
Posts
133
Reactions
63
Resources
0
Uhm, the plugin is cool Im gonna use it but, it announces a player that is OP, because he has all the permissions '-' how do I fix that?

In your permissions plugin, remove the permission: rannouncer.announce
 
Status
This thread has been locked.
Top