Discussion: Plugin Prices

[Justis]

CSquared, Shadow, Jeez, you're both right.
You should always document your code, certainly.
You should also always write efficiently, cutting down your function size is *usually* but not always, more efficient, and *normally* but not always, makes it easier to read.
In instances where it doesn't you should use your best judgement as an experienced developer to decide which is more valuable for that particular occasion.
There might be disagreements on case by case basis, but nobody here is forced to collaborate with each other on a project, so lets not get in fist fights over disagreements on three lines of inconsequential pseudocode.

 

[CSquared]

CSquared, Shadow, Jeez, you're both right.
You should always document your code, certainly.
You should also always write efficiently, cutting down your function size *usually* but not always, more efficient, and *normally* but not always, makes it easier to read.
In instances where it doesn't you should use your best judgement as an experienced developer to decide which is more valuable for that particular occasion.
There might be disagreements on case by case basis, but nobody here is forced to collaborate with each other on a project, so lets not get in fist fights over disagreements on three lines of inconsequential pseudocode.

I don't think it got heated, just some intellectual debate.

 

[Shadow]

Also you wouldn't see a performance impact at all. The compiler optimizes the code when you compile it.

 

[TheRealDan]

Also you wouldn't see a performance impact at all. The compiler optimizes the code when you compile it.

How accurate is this?

I wouldn't be surprised if this happened to a certain extent, but I often spend a fair amount of time optimizing code that would otherwise be irrelevant if this is so.

 

[Justis]

Also you wouldn't see a performance impact at all. The compiler optimizes the code when you compile it.

How accurate is this?

I wouldn't be surprised if this happened to a certain extent, but I often spend a fair amount of time optimizing code that would otherwise be irrelevant if this is so.

There's only so much a compiler can do to optimize what you give it.
The example Shadow gave was something so small, nobody would even think to care whether you put it one way or another.
And then they had a huge argument over it.

What I was talking about was stuff that really matters, like storing data within an improper scope, duplicating content/processes unnecessarily, things that could actually effect performance are usually design flaws in your program, which a compiler cannot fix with it's micro-optimizations. (Which btw, are already unreliably specific)

 

[Shadow]

How accurate is this?

I wouldn't be surprised if this happened to a certain extent, but I often spend a fair amount of time optimizing code that would otherwise be irrelevant if this is so.

There's only so much a compiler can do to optimize what you give it.
The example Shadow gave was something so small, nobody would even think to care whether you put it one way or another.
And then they had a huge argument over it.

What I was talking about was stuff that really matters, like storing data within an improper scope, duplicating content/processes unnecessarily, things that could actually effect performance are usually design flaws in your program, which a compiler cannot fix with it's optimizations.

If you consider that a huge argument then you must have never experienced a argument. I recommend you watch the elction debates. That will teach you what a huge argument is.

 

[Justis]

If you consider that a huge argument then you must have never experienced a argument. I recommend you watch the elction debates. That will teach you what a huge argument is.

You're the one that was so overwhelmed by it you had to say "I'm not going to argue with you" before failing to drop a t-rekt

 

[Shadow]

You're the one that was so overwhelmed by it you had to say "I'm not going to argue with you" before failing to drop a :rekt:

? LOL. First off, learn the definition of half. Its either you don't know it or you cant read. The second thing is I said I am not going to argue with you because if I am not going to change his opinion why argue. Third at least the face of my profile pic doesn't look like a 2 year old that found markers for the first time. :rekt::rekt::rekt:

 

[Shadow]

The most advanced thing the Compiler can do towards optimization is String Demultiplication

But seriously, if you have to rely on the Compiler for optimisation, something's flawed.

If you looked at the code I was referencing to, the compiler would optimize it so it wouldn't have any more of a performance impact than the first thing.

 

[Shadow]

Still not a reason to leave it for the Compiler

So you are saying that you would always use this

var result = methodOne(methodTwo(a, methodThree(b)), c, d);

instead of this

var result3 = methodThree(b);
var result2 = methodTwo(a, result3);
var result = methodOne(result2, c, d);

 

[JC_Plays_MC]

So you are saying that you would always use this

var result = methodOne(methodTwo(a, methodThree(b)), c, d);

instead of this

var result3 = methodThree(b);
var result2 = methodTwo(a, result3);
var result = methodOne(result2, c, d);

Yes. The second way seems pointless as you're wasting more time assigning variables you only plan to use once.

 

[Shadow]

Yes. The second way seems pointless as you're wasting more time assigning variables you only plan to use once.

When you code you don't need to have indentations or comments. We use them because when you go back to read over the code you want it to be easy to read. That is why we use indentations and spaces etc. If you are reading through your code it will take you longer to see what the first version is trying to do than the second version.

 

[JC_Plays_MC]

When you code you don't need to have indentations or comments. We use them because when you go back to read over the code you want it to be easy to read. That is why we use indentations and spaces etc. If you are reading through your code it will take you longer to see what the first version is trying to do than the second version.

Well when you simply add the following above it:

//This executes method 1-3

You're argument is rather poor in this situation as you're taking about indentations when that literally has nothing to do with what you're trying to argue. So simple answer is use comments makes life 10x easier.

 

[Shadow]

Well when you simply add the following above it:

//This executes method 1-3

You're argument is rather poor in this situation as you're taking about indentations when that literally has nothing to do with what you're trying to argue. So simple answer is use comments makes life 10x easier.

You shouldn't use a comment for just 1 line of code.

 

[Justis]

You shouldn't use a comment for just 1 line of code.

You should if that one line of code is so important you'd feel the need to create three separate local variables for it.

 

[JC_Plays_MC]

You shouldn't use a comment for just 1 line of code.

You shouldn't use 3 variables for something that can be done in one line of code. Comments literally don't affect runtime at all so you can and should use as many as you want.

 

[Shadow]

You should if that one line of code is so important you'd feel the need to create three separate local variables for it.

If you would like to look at the official java conventions: http://www.oracle.com/technetwork/java/codeconventions-150003.pdf
at section 5 it says:
"Note: The frequency of comments sometimes reflects poor quality of code. When you feel compelled to add a comment, consider rewriting the code to make it clearer."